skip modifier transforming for enum constants

added simple test
added changelog
fixed #290

src/main/java/de/plushnikov/intellij/plugin/processor/modifier/FieldDefaultsModifierProcessor.java

@@ -3,10 +3,13 @@
 import com.google.common.collect.Iterables;
 import com.intellij.psi.PsiAnnotation;
 import com.intellij.psi.PsiClass;
+import com.intellij.psi.PsiElement;
+import com.intellij.psi.PsiEnumConstant;
 import com.intellij.psi.PsiField;
 import com.intellij.psi.PsiModifier;
 import com.intellij.psi.PsiModifierList;
 import com.intellij.psi.util.PsiTreeUtil;
+import de.plushnikov.intellij.plugin.psi.LombokLightFieldBuilder;
 import de.plushnikov.intellij.plugin.util.PsiAnnotationSearchUtil;
 import de.plushnikov.intellij.plugin.util.PsiAnnotationUtil;
 import lombok.AccessLevel;
@@ -27,7 +30,9 @@ public class FieldDefaultsModifierProcessor implements ModifierProcessor {
   public boolean isSupported(@NotNull PsiModifierList modifierList) {
 
     // FieldDefaults only change modifiers of class fields
-    if (!(modifierList.getParent() instanceof PsiField)) {
+    // but nor for enum constants or lombok generated fields
+    final PsiElement psiElement = modifierList.getParent();
+    if (!(psiElement instanceof PsiField) || psiElement instanceof PsiEnumConstant || psiElement instanceof LombokLightFieldBuilder) {
       return false;
     }
 

src/main/resources/META-INF/plugin.xml

@@ -262,7 +262,7 @@
 		<ul>
 		<li>0.15
 				<ol>
-            <li>Fixed #xxx: </li>
+            <li>Fixed #290: Getter and FieldDefaults with parameter AccessLevel in Enum shows "cannot access"</li>
 				</ol>
 			</li>
 		<li>0.14

src/main/resources/messages/lombokBundle.properties

@@ -20,7 +20,7 @@ config.warn.dependency.outdated.message=<br>\
 
 daemon.donate.title=Lombok support plugin updated to v{0}
 daemon.donate.content=\
-- Fixed (<a href="https://github.com/mplushnikov/lombok-intellij-plugin/issues/322">#322</a>): Added support of lombok.experimental.var<br>\
+- Fixed (<a href="https://github.com/mplushnikov/lombok-intellij-plugin/issues/290">#290</a>): Getter and FieldDefaults with parameter AccessLevel in Enum shows "cannot access"<br>\
 - and other issues...<br>\
   <br>\
   <span style="font-size: 140%">If you find my plugin helpful, donate me using \

src/test/java/de/plushnikov/intellij/plugin/inspection/FieldDefaultsOnEnumInspectionTest.java

@@ -0,0 +1,20 @@
+package de.plushnikov.intellij.plugin.inspection;
+
+import com.intellij.codeInspection.InspectionProfileEntry;
+
+public class FieldDefaultsOnEnumInspectionTest extends LombokInspectionTest {
+
+  @Override
+  protected String getTestDataPath() {
+    return TEST_DATA_INSPECTION_DIRECTORY + "/fielddefaults";
+  }
+
+  @Override
+  protected InspectionProfileEntry getInspection() {
+    return null;
+  }
+
+  public void testEnumClass() throws Exception {
+    doTest();
+  }
+}

src/test/java/de/plushnikov/intellij/plugin/inspection/FieldMayBeFinalInspectionTest.java

@@ -0,0 +1,42 @@
+package de.plushnikov.intellij.plugin.inspection;
+
+import com.intellij.codeInspection.InspectionProfileEntry;
+import com.siyeh.ig.style.FieldMayBeFinalInspection;
+
+public class FieldMayBeFinalInspectionTest extends LombokInspectionTest {
+
+  @Override
+  protected String getTestDataPath() {
+    return TEST_DATA_INSPECTION_DIRECTORY + "/canBeFinalInspection";
+  }
+
+  @Override
+  protected InspectionProfileEntry getInspection() {
+    return new FieldMayBeFinalInspection();
+  }
+
+  public void testClassNormal() throws Exception {
+    doTest();
+  }
+
+  public void testClassWithData() throws Exception {
+    doTest();
+  }
+
+  public void testClassWithFieldSetter() throws Exception {
+    doTest();
+  }
+
+  public void testClassWithGetter() throws Exception {
+    doTest();
+  }
+
+  public void testClassWithSetter() throws Exception {
+    doTest();
+  }
+
+  public void testClassWithValue() throws Exception {
+    doTest();
+  }
+
+}

src/test/java/de/plushnikov/intellij/plugin/action/intellij/FieldMayBeFinalInspectionTest.java → src/test/java/de/plushnikov/intellij/plugin/inspection/LombokInspectionTest.java

@@ -1,33 +1,33 @@
-package de.plushnikov.intellij.plugin.action.intellij;
+package de.plushnikov.intellij.plugin.inspection;
 
-import com.intellij.codeInspection.InspectionProfileEntry;
 import com.intellij.openapi.module.Module;
 import com.intellij.openapi.projectRoots.JavaSdk;
 import com.intellij.openapi.projectRoots.Sdk;
 import com.intellij.openapi.roots.ContentEntry;
 import com.intellij.openapi.roots.LanguageLevelModuleExtension;
 import com.intellij.openapi.roots.ModifiableRootModel;
+import com.intellij.openapi.vfs.newvfs.impl.VfsRootAccess;
 import com.intellij.pom.java.LanguageLevel;
 import com.intellij.testFramework.LightProjectDescriptor;
+import com.intellij.testFramework.PsiTestUtil;
 import com.intellij.testFramework.fixtures.DefaultLightProjectDescriptor;
+import com.intellij.util.PathUtil;
 import com.siyeh.ig.LightInspectionTestCase;
-import com.siyeh.ig.style.FieldMayBeFinalInspection;
 import org.jetbrains.annotations.NotNull;
 
-public class FieldMayBeFinalInspectionTest extends LightInspectionTestCase {
+import java.io.File;
 
-  @Override
-  protected String getTestDataPath() {
-    return "testData/inspection/canBeFinalInspection";
-  }
+import static com.intellij.testFramework.LightPlatformTestCase.getModule;
+
+public abstract class LombokInspectionTest extends LightInspectionTestCase {
+  static final String TEST_DATA_INSPECTION_DIRECTORY = "testData/inspection";
 
   @Override
   public void setUp() throws Exception {
     super.setUp();
-    myFixture.addClass("package lombok;\npublic @interface Setter { }");
-    myFixture.addClass("package lombok;\npublic @interface Getter { }");
-    myFixture.addClass("package lombok;\npublic @interface Data { }");
-    myFixture.addClass("package lombok;\npublic @interface Value { }");
+    final String lombokLibPath = PathUtil.toSystemIndependentName(new File(TEST_DATA_INSPECTION_DIRECTORY, "lib").getAbsolutePath());
+    VfsRootAccess.allowRootAccess(lombokLibPath);
+    PsiTestUtil.addLibrary(getModule(), "Lombok", lombokLibPath, "lombok.jar");
   }
 
   @NotNull
@@ -45,34 +45,4 @@ public void configureModule(@NotNull Module module, @NotNull ModifiableRootModel
       }
     };
   }
-
-  @Override
-  protected InspectionProfileEntry getInspection() {
-    return new FieldMayBeFinalInspection();
-  }
-
-  public void testClassNormal() throws Exception {
-    doTest();
-  }
-
-  public void testClassWithData() throws Exception {
-    doTest();
-  }
-
-  public void testClassWithFieldSetter() throws Exception {
-    doTest();
-  }
-
-  public void testClassWithGetter() throws Exception {
-    doTest();
-  }
-
-  public void testClassWithSetter() throws Exception {
-    doTest();
-  }
-
-  public void testClassWithValue() throws Exception {
-    doTest();
-  }
-
 }

test-manual/src/main/java/de/plushnikov/fielddefault/issue290/EnumClass.java

@@ -0,0 +1,11 @@
+package de.plushnikov.fielddefault.issue290;
+
+import lombok.AccessLevel;
+import lombok.Getter;
+import lombok.experimental.FieldDefaults;
+
+@Getter
+@FieldDefaults(level = AccessLevel.PRIVATE, makeFinal = true)
+public enum EnumClass {
+  ENUM1, ENUM2
+}

test-manual/src/main/java/de/plushnikov/fielddefault/issue290/OtherClass.java

@@ -0,0 +1,7 @@
+package de.plushnikov.fielddefault.issue290;
+
+public class OtherClass {
+  public static void main(String[] args) {
+    System.out.println(EnumClass.ENUM1.name());
+  }
+}

testData/inspection/fielddefaults/EnumClass.java

@@ -0,0 +1,15 @@
+import lombok.AccessLevel;
+import lombok.Getter;
+import lombok.experimental.FieldDefaults;
+
+@Getter
+@FieldDefaults(level = AccessLevel.PRIVATE, makeFinal = true)
+public enum EnumClass {
+  ENUM1, ENUM2
+}
+
+class SomeOtherClass {
+  public static void main(String[] args) {
+    System.out.println(EnumClass.ENUM1.name());
+  }
+}