Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py lacks shebang #77

Closed
vks opened this issue Apr 24, 2008 · 10 comments
Closed

setup.py lacks shebang #77

vks opened this issue Apr 24, 2008 · 10 comments
Labels
bug an unexpected problem or unintended behavior imported Priority-Medium
Milestone

Comments

@vks
Copy link
Contributor

vks commented Apr 24, 2008

$ ./setup.py install  
./setup.py: line 1: from: command not found  
: command not found  
'/setup.py: line 3: syntax error near unexpected token `name='mpmath',
'/setup.py: line 3:`setup(name='mpmath',  
$ python setup.py install
running install  
running build  
running build_py 
[...]                               

This is trivial, simple #!python in the first line would do the job.

Original issue for #77: http://code.google.com/p/mpmath/issues/detail?id=37

Original author: https://code.google.com/u/Vinzent.Steinberg@gmail.com/

@vks
Copy link
Contributor Author

vks commented Apr 23, 2008

runtests.py is affected too.

Original comment: http://code.google.com/p/mpmath/issues/detail?id=37#c1

Original author: https://code.google.com/u/Vinzent.Steinberg@gmail.com/

@fredrik-johansson
Copy link
Collaborator

Added. Let me know if it works.

Original comment: http://code.google.com/p/mpmath/issues/detail?id=37#c2

Original author: https://code.google.com/u/111502149103757882156/

@vks
Copy link
Contributor Author

vks commented Apr 25, 2008

It doesn't work for some reason, please change it to the more conservative approach:

#!/usr/bin/env python

This time I tested it to be sure. Sorry, I should have done this before.

Original comment: http://code.google.com/p/mpmath/issues/detail?id=37#c3

Original author: https://code.google.com/u/Vinzent.Steinberg@gmail.com/

@fredrik-johansson
Copy link
Collaborator

Fixed. Please check again :)

Original comment: http://code.google.com/p/mpmath/issues/detail?id=37#c4

Original author: https://code.google.com/u/111502149103757882156/

@vks
Copy link
Contributor Author

vks commented May 1, 2008

Sadly it doesn't work one Linux probably due to Windows line endings. But I don't 
expect you to change line endings to Unix encoding. Just leave it as it is (anyone 
can convert the line endings easily if he needs or just use python setup.py) and 
thanks for adding the shebangs.

Original comment: http://code.google.com/p/mpmath/issues/detail?id=37#c5

Original author: https://code.google.com/u/Vinzent.Steinberg@gmail.com/

@certik
Copy link
Contributor

certik commented May 1, 2008

Yeah, the line endings issues are annoying. But it seems to me that unix line endings
kind of work everywhere, don't they?

Original comment: http://code.google.com/p/mpmath/issues/detail?id=37#c6

Original author: https://code.google.com/u/104039945248245758823/

@vks
Copy link
Contributor Author

vks commented May 2, 2008

Yes, but not all Windows editors support them. Notepad for example. I don't which
editor Fredrik is using (surely not Notepad :), and this issue is very very minor. I
don't know if it's worth it to swap to unix line endings. Every good editor can
handle all kinds of line endings though.

Original comment: http://code.google.com/p/mpmath/issues/detail?id=37#c7

Original author: https://code.google.com/u/Vinzent.Steinberg@gmail.com/

@certik
Copy link
Contributor

certik commented May 2, 2008

We have exactly the same problem with sympy, or any other project. Imho one just has
to choose one way and stick to that. And fix all problems with it.

Original comment: http://code.google.com/p/mpmath/issues/detail?id=37#c8

Original author: https://code.google.com/u/104039945248245758823/

@fredrik-johansson
Copy link
Collaborator

My editor supports unix line endings. I haven't thought of making this the default,
but I guess I should.

Original comment: http://code.google.com/p/mpmath/issues/detail?id=37#c9

Original author: https://code.google.com/u/111502149103757882156/

@skirpichev
Copy link
Collaborator

I think this is fixed.

@skirpichev skirpichev added this to the next-release milestone Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug an unexpected problem or unintended behavior imported Priority-Medium
Projects
None yet
Development

No branches or pull requests

4 participants