Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't resize file picker window #25

Closed
frnmz opened this issue Dec 27, 2021 · 9 comments
Closed

Can't resize file picker window #25

frnmz opened this issue Dec 27, 2021 · 9 comments
Labels
bug Something isn't working

Comments

@frnmz
Copy link

frnmz commented Dec 27, 2021

Steps to reproduce

Steps to reproduce the behavior:

  1. Open file picker either from preferences or import menu
  2. Try to resize the window

Current behavior

Can't resize file picker window

Version information

  • Application: 0.2.0
  • CryFS (if related): I do not install CryFS because theres no such package in fedora rpm repo
  • Gocryptfs (if related): 1.8.0
  • Distribution: Fedora 35

Additional information

Kooha-12-27-2021-17-33-47.mp4
@mpobaschnig
Copy link
Owner

I can't reproduce this here. However, the area to resize is small and cursor-icon doesn't change, but resize does work. Can you try again with the cursor more precisely on the edge or shadow of the dialog? If it doesn't work, can you resize the window with super + secondary-click (GNOME Tweaks Application -> Windows-> Resize with Secondary-Click)?

I'm also not sure if this is Vaults related, since I don't do fancy stuff but just call GTK-builtin FileChooserDialog.

@frnmz
Copy link
Author

frnmz commented Dec 27, 2021

However, the area to resize is small and cursor-icon doesn't change, but resize does work.

Ahh yes it is indeed like you said.

I'm also not sure if this is Vaults related, since I don't do fancy stuff but just call GTK-builtin FileChooserDialog.

I think it might be related to Vaults using GTK4? But if that the case, Kooha is using the same GTK4 but the curson-icon does change and the area to resize is normal.

@frnmz
Copy link
Author

frnmz commented Dec 27, 2021

@mpobaschnig sorry this is out of topic, gocryptfs documentations mention this:
Also, keep a copy of your master key (printed on mount) in a safe place. This allows you to access the data even if the gocryptfs.conf config file is damaged or you lose the password.

do you know what they mean by master key? is it gocryptfs.conf file?

@mpobaschnig
Copy link
Owner

I think it might be related to Vaults using GTK4? But if that the case, Kooha is using the same GTK4 but the curson-icon does change and the area to resize is normal.

Kind of, yes, just tested it. This comes from the dialogs that have modal not set to true. It seems not all dialogs of Vaults have modal set to true, so some of them behave like this. I will fix this later on.

@mpobaschnig sorry this is out of topic, gocryptfs documentations mention this: Also, keep a copy of your master key (printed on mount) in a safe place. This allows you to access the data even if the gocryptfs.conf config file is damaged or you lose the password.

do you know what they mean by master key? is it gocryptfs.conf file?

When creating a vault with gocryptfs in command line, you get a master key that you can use to decrypt your data in case your config file is corrupted (bitrot, ...) or you forget your password. This is only printed on vault creation.

Not sure if it's worth it to expose this to users since you still have to backup everything properly regardless, and KDE Vault also doesn't show this to users.

@frnmz
Copy link
Author

frnmz commented Dec 28, 2021

in case your config file is corrupted (bitrot, ...)

So it will be fine as long as I have a backup of the conf file right?

Not sure if it's worth it to expose this to users since you still have to backup everything properly regardless, and KDE Vault also doesn't show this to users.

Still I think it's worth mentioning it though... At least telling the users to backup their conf file.
Because having an unencrypted version of file as a backup kinda defeating its purpose...

@mpobaschnig
Copy link
Owner

So it will be fine as long as I have a backup of the conf file right?

Yes, gocryptfs.conf and remembering its password to decrypt.

Still I think it's worth mentioning it though... At least telling the users to backup their conf file.
Because having an unencrypted version of file as a backup kinda defeating its purpose...

Can you please create a new issue where we can further discuss this, so we can stay on-topic here.

@mpobaschnig mpobaschnig added the bug Something isn't working label Dec 29, 2021
@3ship
Copy link

3ship commented Jan 5, 2022

May or may not be related to this, but the file picker window increases in size every time I open it.

On the Flatpak build 0.2.1, but it also happened in 0.1

@mpobaschnig
Copy link
Owner

This happens only on X11, not on Wayland, for me. Not sure if this is actually Vaults related, but you want you can create an issue for that if you want.

@mpobaschnig
Copy link
Owner

Guess this can be closed now, since all dialogs are set to modal now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

3 participants