Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing support for TURN relay #24

Closed
9a4gl opened this issue Apr 1, 2017 · 5 comments
Closed

Missing support for TURN relay #24

9a4gl opened this issue Apr 1, 2017 · 5 comments

Comments

@9a4gl
Copy link
Contributor

9a4gl commented Apr 1, 2017

I will create a patch and send you as I already have that implemented locally

@9a4gl
Copy link
Contributor Author

9a4gl commented Apr 1, 2017

0001-Add-support-for-TURN-relay.patch.txt

Please review and merge upstream if you agree with change.

@mpromonet
Copy link
Owner

Hi,
Thanks, it is more convenient to submit modifications as a pull request.
Regards
Michel.

@9a4gl
Copy link
Contributor Author

9a4gl commented Apr 1, 2017

I would do that, but I cannot push. I am new at github, do you need to allow me to push on your repo or ? Help me and I will do that :)

@mpromonet
Copy link
Owner

Hi,
The standard way to process with GitHub is to fork my repo, push the modification to your forked repo and submit a pull request to my repo.
Then it is easy to see the difference and accept the pull request.
Best Regards,
Michel.

@9a4gl
Copy link
Contributor Author

9a4gl commented Apr 1, 2017

Thanks, forking sounded to me like expensive operation that should be used if I want to split from your project. Ok, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants