You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The correct definition would set the value to 273.15. This definition sets it to the representable double precision floating point number that is closest to 273.15. Although the difference is extremely tiny, it is enough to prevent valid integer-type-only use cases that use exact reasoning (for example, converting between millikelvins and millidegrees Celsius).
I'm not sure about the absolute best way to proceed, but I bet it would be good to use an integer to define this value rather than floating point.
The text was updated successfully, but these errors were encountered:
I didn't want to hijack #537, but I noticed this line in it:
mp-units/src/systems/si/include/mp-units/systems/si/units.h
Line 77 in e01942c
The correct definition would set the value to 273.15. This definition sets it to the representable double precision floating point number that is closest to 273.15. Although the difference is extremely tiny, it is enough to prevent valid integer-type-only use cases that use exact reasoning (for example, converting between millikelvins and millidegrees Celsius).
I'm not sure about the absolute best way to proceed, but I bet it would be good to use an integer to define this value rather than floating point.
The text was updated successfully, but these errors were encountered: