feat: allow user to disable pre-generated write cache #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is an old PR, but I wanted to bump it. I also encountered the same use case and this PR would fix our issue nicely. In my case, our project swaps all MQTT imports with the At the moment, we're unable to remove the |
|
@mwohlert Can you add a unit test for this? |
robertsLando
changed the title
|
Hi @robertsLando, I added a unit test on behalf of @mwohlert |
robertsLando
approved these changes
Jun 29, 2023
robertsLando
added a commit
that referenced
this pull request
Jul 3, 2023
…1622) @vishnureddy17 Fix typo in README 00bf657 @bverhoeven Fix memory leak in subscription topic mapping (#1535) 8c77eec @mwohlert @robertsLando @ynagasaki feat: allow user to disable pre-generated write cache (#1151) 0d11888 Co-authored-by: Daniel Lando <daniel.sorridi@gmail.com> Co-authored-by: Yoshi Nagasaki <yn253@cornell.edu> Co-authored-by: Dmitry Kurmanov <kurmanov.work@gmail.com> Co-authored-by: Vishnu Reddy <vishnureddy@microsoft.com> Co-authored-by: Bas Verhoeven <soczol@gmail.com> Co-authored-by: Michel Wohlert <michel.wohlert@gmail.com>
|
@ynagasaki This will be available on next beta. Doing it right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the user of the library to disable the pre-generated write cache generated by mqtt-packet and instead rely on in-flight generated buffers. This helps to preserve memory in low-memory environments, but possibly degrading mqtt-stream write performance.