Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RangeError: Maximum call stack size exceeded #1385

Closed
NorthernMan54 opened this issue Dec 28, 2021 · 8 comments
Closed

RangeError: Maximum call stack size exceeded #1385

NorthernMan54 opened this issue Dec 28, 2021 · 8 comments
Assignees

Comments

@NorthernMan54
Copy link

Over in the Homebridge community we are chasing down an issue that is triggered by having multiple homebridge plugins leveraging MQTT and exposes this issue with the collections package. montagejs/collections#241

Looking thru the commits for mqtt, #1301 back in the summer exposed the issue.

Leaving this here incase others are experiencing the same issue.

Reported problems

NorthernMan54/homebridge-alexa#481
dgreif/ring#844
Sunoo/homebridge-camera-ffmpeg#1240

@NorthernMan54
Copy link
Author

At the present time we are recommending that the impacted plugins pin the mqtt dependancy to mqtt version 4.2.8 to workaround the issue.

@YoDaMa
Copy link
Contributor

YoDaMa commented Dec 29, 2021

can @NorthernMan54 confirm the fix in #1386 fixes the issue the HomeBridge community is seeing?

@YoDaMa YoDaMa self-assigned this Dec 29, 2021
@NorthernMan54
Copy link
Author

@YoDaMa I can confirm that collections 5.1.13 and number-allocator 1.0.8 resolves the issue ( just finished testing this )

@YoDaMa
Copy link
Contributor

YoDaMa commented Dec 29, 2021

ok, I will release a patch update this morning.

@YoDaMa
Copy link
Contributor

YoDaMa commented Dec 29, 2021

released. please validate. https://github.com/mqttjs/MQTT.js/pull/1386/files and #1388 handled this bug.

@NorthernMan54
Copy link
Author

Removed the workarounds, and updated everything. And can confirm that issue is resolved. Tks very much

@NorthernMan54
Copy link
Author

PS And a big thanks for your support on this issue from the Homebridge community

@YoDaMa
Copy link
Contributor

YoDaMa commented Dec 30, 2021

you're welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants