fix(types): missing null declaration for error in subscription callback #1589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The callback that can be passed to client.subscribe can be invoked with null as observed in link below, https://github.com/mqttjs/MQTT.js/blob/b3ce3da84147c86eb176759f53fa929e96de7969/lib/client.js#L784 The type of the callback does not reflect this and assumes an error is always present. This patch fixes this.
robertsLando
approved these changes
Jun 23, 2023
robertsLando
changed the title
robertsLando
pushed a commit
that referenced
this pull request
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The callback that can be passed to client.subscribe can be invoked with null as observed in link below,
MQTT.js/lib/client.js
Line 784 in b3ce3da
The type of the callback does not reflect this and assumes an error is always present. This patch fixes this.