Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: consistency, used this instead of that #1618

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Conversation

robertsLando
Copy link
Member

By looking at the code I found that in some anonimous functions both this and that were used. Giving that this happens on events listeners both works but it would be better to only use one for consistency

@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (8d68c8c) 86.25% compared to head (be11701) 86.25%.

❗ Current head be11701 differs from pull request most recent head d651ee5. Consider uploading reports for the commit d651ee5 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1618   +/-   ##
=======================================
  Coverage   86.25%   86.25%           
=======================================
  Files          13       13           
  Lines        1317     1317           
=======================================
  Hits         1136     1136           
  Misses        181      181           
Impacted Files Coverage Δ
lib/client.js 90.90% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@robertsLando robertsLando merged commit 800825b into main Jun 28, 2023
4 checks passed
@robertsLando robertsLando deleted the fix-this-that branch June 28, 2023 15:34
robertsLando added a commit that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants