Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use explicit connect packet and infer types from mqtt-packet #1646

Merged
merged 5 commits into from
Jul 24, 2023

Conversation

robertsLando
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch coverage: 40.00% and project coverage change: -0.20 ⚠️

Comparison is base (0f29bff) 81.43% compared to head (e814238) 81.23%.

❗ Current head e814238 differs from pull request most recent head b8a7c33. Consider uploading reports for the commit b8a7c33 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1646      +/-   ##
==========================================
- Coverage   81.43%   81.23%   -0.20%     
==========================================
  Files          21       21              
  Lines        1325     1327       +2     
  Branches      316      318       +2     
==========================================
- Hits         1079     1078       -1     
- Misses        173      175       +2     
- Partials       73       74       +1     
Impacted Files Coverage Δ
src/lib/client.ts 86.03% <40.00%> (-0.39%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@robertsLando robertsLando changed the title fix: use explicit connect packet fix: use explicit connect packet and infer types from mqtt-packet Jul 24, 2023
@robertsLando robertsLando merged commit 2a49ed3 into main Jul 24, 2023
6 checks passed
@robertsLando robertsLando deleted the explicit-connect branch July 24, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant