fix: resubscribe when no session present (#895) #1650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertsLando
requested changes
Jul 27, 2023
| @@ -2106,7 +2106,7 @@ export default class MqttClient extends TypedEventEmitter<MqttClientEventCallbac | |||
| if ( | |||
| !this._firstConnection && | |||
| (this.options.clean || | |||
| (this.options.protocolVersion === 5 && | |||
There was a problem hiding this comment.
Could you add a comment here with the links to MQTT 3.1.1 specs that explain this?
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1650 +/- ##
=======================================
Coverage 81.11% 81.11%
=======================================
Files 21 21
Lines 1366 1366
Branches 324 324
=======================================
Hits 1108 1108
Misses 181 181
Partials 77 77
☔ View full report in Codecov by Sentry. |
robertsLando
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The combination clean=false, resubscribe=true, sessionPresent=false should now trigger a resubscribe for MQTT v3.1.1, not only for v5.
Closes #895
Closes #1288