fix: move exported types out of dev dependencies #1676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markormesher
changed the title
markormesher
changed the title
markormesher
changed the title
robertsLando
changed the title
robertsLando
approved these changes
Aug 21, 2023
|
What's the schedule for cutting releases of this library? Would be great to upgrade this in some projects over the weekend. |
|
I'm on vacation right now so probably next week |
|
any update on this? |
|
@andrewperella This change should be in 5.0.4 onwards |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The types that are exported for this project use types from
readable-streamandws, so those types need to be included as proper dependencies that get shipped to consumers. This PR moves those dependencies out of the dev block, and also bumps the Node types to make sure they work with the latest additions to thereadable-streamtypes (i.e. usingasyncDispose).This ought to fix #1673 (it does for one of my project seeing the same error as that issue).
One downside of this is that consuming projects will need to be on a fairly recent version of
@types/node, but I don't think that's the worst thing vs. not working at all for TS projects right now.