Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import type error #1705

Merged
merged 3 commits into from
Oct 4, 2023
Merged

fix: import type error #1705

merged 3 commits into from
Oct 4, 2023

Conversation

JimmyBjorklund
Copy link
Contributor

node_modules/mqtt/build/lib/shared.d.ts:3:13 - error TS1259: Module '"stream"' can only be default-imported using the 'esModuleInterop' flag

3 import type internal from 'stream';
~~~~~~~~

node_modules/@types/node/stream.d.ts:1726:5
1726 export = internal;
~~~~~~~~~~~~~~~~~~
This module is declared with 'export =', and can only be used with a default import when using the 'esModuleInterop' flag.

Found 1 error in node_modules/mqtt/build/lib/shared.d.ts:3

src/lib/shared.ts Show resolved Hide resolved
@robertsLando robertsLando changed the title fix: Fixed import to remove error fix: fixed import to remove error Sep 29, 2023
@robertsLando robertsLando changed the title fix: fixed import to remove error fix: import type error Sep 29, 2023
src/lib/shared.ts Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (069605b) 81.03% compared to head (618e8b2) 81.03%.
Report is 1 commits behind head on main.

❗ Current head 618e8b2 differs from pull request most recent head a955a0f. Consider uploading reports for the commit a955a0f to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1705   +/-   ##
=======================================
  Coverage   81.03%   81.03%           
=======================================
  Files          21       21           
  Lines        1366     1366           
  Branches      323      323           
=======================================
  Hits         1107     1107           
  Misses        182      182           
  Partials       77       77           
Files Coverage Δ
src/lib/shared.ts 83.33% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robertsLando robertsLando enabled auto-merge (squash) October 4, 2023 12:09
@robertsLando robertsLando merged commit 0960b68 into mqttjs:main Oct 4, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants