Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not remove nodejs support in minor versions please #1710

Closed
Apollon77 opened this issue Oct 8, 2023 · 4 comments
Closed

Do not remove nodejs support in minor versions please #1710

Apollon77 opened this issue Oct 8, 2023 · 4 comments

Comments

@Apollon77
Copy link

Hi, it seems that you removed support for Node.js 16.x in 5.1.0 (069605b#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L95) ... this makes a lot issues when dependenciesare used as normalyl with carets.

If this was wanted a reverting 5.1.x and a new major version yowould be great for this. :-)

@robertsLando
Copy link
Member

@Apollon77 I'm sorry for the incovenience with that, I totally forgot that line when merging the PR. Giving that that change is only needed for tests, would it be ok for you If I only fix the engines in package.json? Everything should work as expexted with node 16 too it's just that it's not compatibile with tests anymore (and also reached EOL)

@Apollon77
Copy link
Author

sure, a patch release that fixes this is absolutely fine. Thank you for your fast reaction and support!

@robertsLando
Copy link
Member

Patch is coming 🙏🏼

@Apollon77
Copy link
Author

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants