fix: make import mqtt from 'mqtt' work in browsers
#1734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users will be able to use `import mqtt from 'mqtt'` directly without using `/dist` imports
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1734 +/- ##
=======================================
Coverage 81.03% 81.03%
=======================================
Files 21 21
Lines 1366 1366
Branches 323 323
=======================================
Hits 1107 1107
Misses 182 182
Partials 77 77 ☔ View full report in Codecov by Sentry. |
robertsLando
changed the title
import mqtt from 'mqtt' work in browsers
robertsLando
changed the title
import mqtt from 'mqtt' work in browsersimport mqtt from 'mqtt' work in browsers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users will be able to use
import mqtt from 'mqtt'directly without using/distimportsFixes #1733