fix: catch all socket errors

[robertsLando]

Fixes #1751

[codecov]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (de89c0d) 79.47% compared to head (3a95d9d) 79.45%.
Report is 1 commits behind head on main.

Files	Patch %	Lines
src/lib/client.ts	50.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1752      +/-   ##
==========================================
- Coverage   79.47%   79.45%   -0.02%     
==========================================
  Files          23       23              
  Lines        1403     1402       -1     
  Branches      329      329              
==========================================
- Hits         1115     1114       -1     
  Misses        209      209              
  Partials       79       79              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[robertsLando]

Apart from the comment I added I didn't found any reason why we are filtering errors to emit. The errors that could happen on connect are a lot and we will always miss some, this PR just ignores all errors that comes from browser Websocket (like it happened before as code in that case is always undefined, explained why here) and emits all errors that happen on nodejs sockets.

Tests are working but I would like to know if someone has a reason why those errors should be filtered. Note that actually we always setup a client.on('error') listener so that would not throw unhandled rejections:

MQTT.js/src/lib/connect/index.ts

Lines 174 to 176 in 6d33a05

	client.on('error', () => {
	/* Automatically set up client error handling */
	})

cc @mcollina @vishnureddy17

[robertsLando]

@mcollina Kindly ping

[mcollina]

lgtm