Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve worker tests #1757

Merged
merged 5 commits into from Dec 5, 2023
Merged

fix: improve worker tests #1757

merged 5 commits into from Dec 5, 2023

Conversation

robertsLando
Copy link
Member

No description provided.

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (38fb6ae) 79.56% compared to head (db279e2) 79.57%.

Files Patch % Lines
src/lib/PingTimer.ts 60.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1757      +/-   ##
==========================================
+ Coverage   79.56%   79.57%   +0.01%     
==========================================
  Files          24       24              
  Lines        1419     1420       +1     
  Branches      332      331       -1     
==========================================
+ Hits         1129     1130       +1     
  Misses        209      209              
  Partials       81       81              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robertsLando
Copy link
Member Author

cc @vishnureddy17 now also web workers are covered by tests 🎉

@robertsLando robertsLando merged commit 4facb18 into main Dec 5, 2023
7 of 8 checks passed
@robertsLando robertsLando deleted the fix-worker-test branch December 5, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant