Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase help-me version to fix vulnerability in glob/inflight #1773

Merged
merged 3 commits into from Jan 23, 2024

Conversation

jackbridger
Copy link
Contributor

Closes #1770
I incremented in package json but should I also include package-lock.json?
Also, the tests were timing out when I ran them (also before I made changes)

@jackbridger jackbridger changed the title increase help-me version to fix vulnerability in glob/inflight fix: increase help-me version to fix vulnerability in glob/inflight Jan 9, 2024
@robertsLando
Copy link
Member

@jackbridger You should run npm install help-me@5.0.0 instead, that will also update package-lock

Copy link
Member

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing package-lock update, use npm install

@jackbridger
Copy link
Contributor Author

Made the change, let me know if I should change anything else. Also thanks for your help.

@robertsLando robertsLando enabled auto-merge (squash) January 23, 2024 14:13
@robertsLando robertsLando merged commit 72f99dc into mqttjs:main Jan 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade help-me to v5.0.0 to resolve Missing Release of Resource after Effective Lifetime
2 participants