Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exposing reconnection attempts and errors #186

Closed
jeloou opened this issue May 19, 2014 · 3 comments
Closed

Exposing reconnection attempts and errors #186

jeloou opened this issue May 19, 2014 · 3 comments

Comments

@jeloou
Copy link
Contributor

jeloou commented May 19, 2014

Hey guys,

I see an issue (#108) mentioning the option reconnectAttempts, but it seems missing now. Also, no event is triggered when the client is trying to reconnect or when it fails. I just added those features to my fork, maybe it can be merged, but couldn't find any contribution rules.

What do you think?
@mcollina
Copy link
Member

Please add unit test for it and submit a pull request.

Thanks a million!

@mcollina
Copy link
Member

I would like to have these in for the upcoming v1.0.0 release (see #232). Would you like to contribute a PR?

@mcollina mcollina mentioned this issue Nov 29, 2014
Merged
18 tasks
@mcollina
Copy link
Member

Everything is exposed and documented in 1.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mcollina @jeloou