text inside Markdown code fences is marked as "#. type: Plain text"

[eighthave]

I think that code inside of the fenced code block should be marked as something other than "Plain text". Most of the text in a fenced code block should not be translated, most likely it will only the code comments that will be translatable. So having this text with another status will highlight this fact to the translator. For example, if there was this code block:

​```console
which open
​```

This would be split up into a POT like this:

#. type: Code fence info string
#, no-wrap
msgid "console"
msgstd ""

#. type: Plain text
#, no-wrap
msgid "which open"
msgstd ""

And many translators would translate both the terms "which open". This would be wrong, since this is actually a UNIX command which with an argument that is the UNIX command open.

I propose that it is labeled using the code fence info string, something like #. type: "console" text. That would also then give things like:

• #. type: "perl" text
• #. type: "bash" text
• #. type: "markdown" text

@uniqx

[eighthave]

@uniqx do you think my proposal for type: "bash" text would be usable in Weblate checkers?

[jonassmedegaard]

I agree, except for the proposed label.

trailing hints are optional and I would find it better to model the label taking that into account, e.g. like this:

#. type: Code block "console"
#, no-wrap
msgid "which open"
msgstd ""

(where only "Code" is mandatory, delimiting space and quotes and quoted part - which can contain multiple words! - is optional)

[eighthave]

#. type: Code block "console" looks great, @uniqx work for you?

[jonassmedegaard]

Quoting Hans-Christoph Steiner (2020-03-20 15:45:09)

`#. type: Code block "console"` looks great, @uniqx work for you?

Since this sounds like having consequences for code of others, let's be more strict and instead use `type: fenced code block` to align with https://spec.commonmark.org/0.29/#code-fence

…

-- * Jonas Smedegaard - idealist & Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private

[eighthave]

Sounds even better, I like following standards!

[jonassmedegaard]

Fix is here: https://salsa.debian.org/debian/po4a/-/commit/17495dc

[mquinson]

Hello,

I cherry-picked the commit from the repo where it was (that is dedicated to the Debian package) and pushed it to the upstream source code on both github and salsa.

Thanks to both of you!