Skip to content
This repository has been archived by the owner on Jul 17, 2021. It is now read-only.

Better detecting of all commit hooks to copy over #6

Closed
mr-feek opened this issue Oct 17, 2017 · 0 comments
Closed

Better detecting of all commit hooks to copy over #6

mr-feek opened this issue Oct 17, 2017 · 0 comments
Labels
enhancement hacktoberfest help wanted

Comments

@mr-feek
Copy link
Owner

mr-feek commented Oct 17, 2017

Detailed description

Currently the files to copy over are hardcoded in an array. This will not be scalable as more hooks are added. It would be nice to not have to maintain a hardcoded list of files to copy.

Possible implementation

Use the Symfony Finder component to find all files in src/hooks ending in .sh.
achmadfatoni added a commit to achmadfatoni/LaravelGitHooks that referenced this issue Oct 18, 2017
@achmadfatoni
mr-feek#6 Better detecting of all commit hooks to copy over
a04baba
achmadfatoni added a commit to achmadfatoni/LaravelGitHooks that referenced this issue Oct 19, 2017
@achmadfatoni
mr-feek#6 type hint Finder in contructor
bb0ec64
mr-feek added a commit that referenced this issue Oct 20, 2017
@mr-feek
Merge pull request #15 from achmadfatoni/detecting_commit_hook_files
532facd 
#6 Better detecting of all commit hooks to copy over
@mr-feek mr-feek closed this as completed Oct 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement hacktoberfest help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mr-feek