We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Like here https://github.com/Mr-Markus/ZigbeeNet/blob/develop/libraries/ZigBeeNet/ZigBeeNetworkManager.cs#L992 we should avoid to call "return await" if possible as the compile will generate a state machine. Just return the Task direcly. In most cases it is not necessary to call await when there is nothing to do after awaiting the task. (It might by when combined with using)
The text was updated successfully, but these errors were encountered:
I made a quick example. Have a look at the difference IL code.
https://sharplab.io/#v2:CYLg1APgAgTAjAWAFBQAwAIpwKwG5nJQDMmM6AwugN7Lp3q30AOATgJYBuAhgC4CmmAGzoASgFcAdgEEAzgE8JAYwD6cABQBKRnRpJ6+zAHYhAOnES1m9AF4AfNQC+G/HvoPtDV3VadeAqAAcQqKSsgoqMJoeugb0UACcpuaWGjb2VE4u+u5IDkA
Sorry, something went wrong.
fixed in PR #90
Thx for quick implementation
No branches or pull requests
Like here https://github.com/Mr-Markus/ZigbeeNet/blob/develop/libraries/ZigBeeNet/ZigBeeNetworkManager.cs#L992 we should avoid to call "return await" if possible as the compile will generate a state machine. Just return the Task direcly. In most cases it is not necessary to call await when there is nothing to do after awaiting the task. (It might by when combined with using)
The text was updated successfully, but these errors were encountered: