Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid return await #81

Closed
nicolaiw opened this issue Nov 18, 2019 · 3 comments
Closed

avoid return await #81

nicolaiw opened this issue Nov 18, 2019 · 3 comments

Comments

@nicolaiw
Copy link
Contributor

Like here https://github.com/Mr-Markus/ZigbeeNet/blob/develop/libraries/ZigBeeNet/ZigBeeNetworkManager.cs#L992 we should avoid to call "return await" if possible as the compile will generate a state machine. Just return the Task direcly. In most cases it is not necessary to call await when there is nothing to do after awaiting the task. (It might by when combined with using)

@spudwebb
Copy link
Contributor

fixed in PR #90

@Mr-Markus
Copy link
Owner

Thx for quick implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants