Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I got it working for zfs #4

Closed
kryptt opened this issue Jun 8, 2020 · 9 comments
Closed

I got it working for zfs #4

kryptt opened this issue Jun 8, 2020 · 9 comments

Comments

@kryptt
Copy link

kryptt commented Jun 8, 2020

If you are interested I can submit a patch to use j-keck/zfs-snap-diff to get this working with zfs if you are interested I am probably prepare a pull request for it...

@priyadarshan
Copy link

I opened #1 back in 2016, and I am still very much interested in using snapshot-timemachine with zfs. Would you give access to your fork, or a patch? Currently I am using zfs on illumos servers (mainly smartOS).

@kryptt
Copy link
Author

kryptt commented Jun 8, 2020

https://github.com/kryptt/snapshot-timemachine

I need to add more error handling, but it currently works on my machine.. let me know

@priyadarshan
Copy link

Thank you. I am currently setting up a new test SmartOS server, and will test it there and report back in a few days.

@priyadarshan
Copy link

A new version of zfs-snap-diff just came out. I will test your patch with latest version.

@mrBliss
Copy link
Owner

mrBliss commented Jun 16, 2020

https://github.com/kryptt/snapshot-timemachine

I need to add more error handling, but it currently works on my machine.. let me know

I'm open to a PR whenever you think your patches are mature 🙂

@j-keck
Copy link

j-keck commented Jun 16, 2020

I'm the author of zfs-snap-diff and was pointed by @priyadarshan to this.

I can change zsd to accept a new flag (maybe -snapshot-timemachine-output?) to
provide a special / stable output for this package.

Just ping me and i can implement the missing parts on my side.

@kryptt
Copy link
Author

kryptt commented Jun 16, 2020

@j-keck yeah, that would be great; right now I'm running it in debug to get a couple of parameters from there.

I will write an issue for you in zfs-snap-diff, yeah?

@j-keck
Copy link

j-keck commented Jun 16, 2020

@kryptt

I will write an issue for you in zfs-snap-diff, yeah?

yes, pelase

@kryptt
Copy link
Author

kryptt commented Jun 24, 2020

I created a separate pull request #5 with 'proper' zfs support

@kryptt kryptt closed this as completed Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants