Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features: iOS8 UIVisualEffectView Support #51

Merged
merged 5 commits into from Oct 13, 2014

Conversation

mrackwitz
Copy link
Owner

Uses UIVisualEffectView in combination with UIBlurEffect for the blur in MRProgressOverlayView.

  • Blocked by iOS 8 GM.
  • Blocked by rdar://18466755. (Specific to "classic" resolution on new phones.)

@marcelofabri
Copy link
Contributor

GM is out now 👍

@mrackwitz
Copy link
Owner Author

Thanks for the reminder. 👍

But there is an issue with UIVisualEffectView only on iPhone 6 and iPhone 6P if a mask is applied, which causes that transformations are applied, which do not only affect offscreen rendering, but also the current screen's contents. This causes again trouble with flickering. 😒
The mask needs to be applied because UIVisualEffectView's layer doesn't support cornerRadius.

@marcelofabri
Copy link
Contributor

Have you tried adding UIVisualEffectView to an UIView and setting the cornerRadius on it (instead of using a mask)?

@mrackwitz
Copy link
Owner Author

@marcelofabri: Yes, I tried it now again on GM, but this still don't work.
Perhaps this is related to something deep in the rendering chain and have to do with the downsampling used on iPhone 6+.

@mrackwitz mrackwitz force-pushed the features/ios8_uivisualeffectview_support branch from cfbff90 to 2f0c311 Compare September 26, 2014 13:08
@mrackwitz
Copy link
Owner Author

Update: Rebased.
I've finally setup a sample project and filed a rdar://18466755 for the flicker issue.

@mrackwitz mrackwitz force-pushed the features/ios8_uivisualeffectview_support branch from 2f0c311 to 860d3a6 Compare October 13, 2014 12:41
@mrackwitz
Copy link
Owner Author

Update: The flickering is specific for using the "classic" resolution on iPhone 6.
So this is now ready for merge and release, as there is an issue with "classic" resolution with the old method, too.

mrackwitz added a commit that referenced this pull request Oct 13, 2014
…w_support

Features: iOS8 UIVisualEffectView Support
@mrackwitz mrackwitz merged commit a3c9564 into master Oct 13, 2014
@mrackwitz mrackwitz deleted the features/ios8_uivisualeffectview_support branch October 13, 2014 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants