Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support hideout ER with savewarp to 1-torch jail #48

Open
fenhl opened this issue Apr 5, 2024 · 1 comment
Open

Support hideout ER with savewarp to 1-torch jail #48

fenhl opened this issue Apr 5, 2024 · 1 comment

Comments

@fenhl
Copy link
Contributor

fenhl commented Apr 5, 2024

Currently, there is no link to the 1-torch jail from the other Thieves' Hideout segments, which matches the behavior on your randomizer fork but not the current behavior on main Dev. (I plan to PR the option to have either behavior eventually, as is the case on my randomizer fork.) An ability to select which variant of hideout ER is used would be nice to have.

@mracsys
Copy link
Owner

mracsys commented Apr 8, 2024

This will be much easier to handle in the rewrite. Connected region visibility with the savewarp works out of the box there. I'll make a note to make sure 1 Torch Jail exits get grouped with the other jails so they can be connected outside.

In the meantime, I'm hesitant to add another special case to the current region visibility scheme with how fragile it is. It loops through each entrance for their connected regions once, then oneways get additional loops to handle chained oneways like Valley -> Lake -> Owl drop at Field. Connections from the 1 Torch Jail might work as-is due to the forward connection into the jail. I'm not sure if decoupled would need additional handling. I'm open to PRs on this if anyone is hungry for spaghetti diving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants