Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCRIPT command corrections #366

Closed
wants to merge 1 commit into from
Closed

SCRIPT command corrections #366

wants to merge 1 commit into from

Conversation

arunoda
Copy link

@arunoda arunoda commented Jan 21, 2013

There is no command(s) like script load. Only has script

if we invoke redisClient['script load']() following error will be raised

Error: ERR unknown command 'script load'
      at ReplyParser.RedisClient.init_parser (/Volumes/edu/projects/dejaset/tusker/node_modules/redis/index.js:260:27)
      at ReplyParser.EventEmitter.emit (events.js:96:17)
      at ReplyParser.send_error (/Volumes/edu/projects/dejaset/tusker/node_modules/redis/lib/parser/javascript.js:293:10)
      at ReplyParser.execute (/Volumes/edu/projects/dejaset/tusker/node_modules/redis/lib/parser/javascript.js:176:22)
      at RedisClient.on_data (/Volumes/edu/projects/dejaset/tusker/node_modules/redis/index.js:476:27)
      at Socket.<anonymous> (/Volumes/edu/projects/dejaset/tusker/node_modules/redis/index.js:79:14)
      at Socket.EventEmitter.emit (events.js:96:17)
      at TCP.onread (net.js:397:14)

There is no command(s) like 'script load'. Only has 'script'
@arunoda
Copy link
Author

arunoda commented Jan 30, 2013

Hey, This is a simple fix. This can be merged automatically.

@jeffomatic
Copy link

+1

@brycebaril
Copy link
Contributor

Any chance you could add some tests for these commands? Thanks!

@DTrejo
Copy link
Contributor

DTrejo commented Feb 18, 2013

Actually, please update generate_commands.js so that it omits these commands, and instead writes only "script".

Thank you,
D

@DTrejo
Copy link
Contributor

DTrejo commented Feb 24, 2013

#363 should fix this!
Please re-submit a PR if this is not the case.

Thank you!
D

@DTrejo DTrejo closed this Feb 24, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants