Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use subprocess32 instead of subprocess #13

Closed
danstender opened this issue Nov 1, 2015 · 4 comments
Closed

use subprocess32 instead of subprocess #13

danstender opened this issue Nov 1, 2015 · 4 comments

Comments

@danstender
Copy link

Hi Michael,

for the Debian package, we've patched afl-cov to import subprocess32 [1] instead of Python 2 stdlib subprocess, which is highly recommended to replace on POSIX systems. Do you would like to apply that upstream?

[1] https://pypi.python.org/pypi/subprocess32/

@mrash
Copy link
Owner

mrash commented Nov 1, 2015

I'd like to take a look at this. Can you point me to a patch?

@danstender
Copy link
Author

The patch is:

--- a/afl-cov
+++ b/afl-cov
@@ -31,7 +31,7 @@
from sys import argv
import errno
import re
-import subprocess
+import subprocess32 as subprocess
import glob
import string
import argparse

I've seen that some apps are using import-if-available constructs like e.g. Ocrodjvu:
https://sources.debian.net/src/ocrodjvu/0.9.1-1/lib/ipc.py/

@danstender
Copy link
Author

We've got afl-cov in Debian now: https://tracker.debian.org/pkg/afl-cov (new package tracker, not yet fully populated).

@mrash
Copy link
Owner

mrash commented Nov 11, 2015

Excellent, thanks.

@mrash mrash closed this as completed in 96ad6ff Dec 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants