-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Absolute value of the output of sinc-based convolutions? #4
Comments
Hi Hervé, |
Thanks for the clarification -- it would make a nice addition to the paper and definitely help others reproduce your experiment. Here is my (slightly more pytorchic) version of |
Great job! thank you! |
It seems that the addition of this abs operation is very important for fast convergence! |
torch.abs
is applied to the output of sinc-based convolutions.SincNet/dnn_models.py
Lines 312 to 313 in 488c982
Why is that? I coudn't find an explanation in the paper.
The text was updated successfully, but these errors were encountered: