Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate new-version branch with release #63

Closed
zkamvar opened this issue May 27, 2019 · 7 comments
Closed

Consolidate new-version branch with release #63

zkamvar opened this issue May 27, 2019 · 7 comments
Assignees

Comments

@zkamvar
Copy link
Collaborator

zkamvar commented May 27, 2019

There are two branches that are ahead of master, new-version and release. It is confusing why both of these should be ahead of master. When comparing these, it appears that release may be slightly ahead of new-version and should be favored: https://github.com/annecori/EpiEstim/compare/new-version..release

@zkamvar
Copy link
Collaborator Author

zkamvar commented May 28, 2019

Scratch that, and reverse it. New version appears to have one more feature from 7680cea

@jstockwin
Copy link
Collaborator

Hey @zkamvar, apologies for the confusion. We're aware of this and will try to get around to resolving it as soon as possible!

The plan is to get both branches merged in to master!

@annecori
Copy link
Collaborator

annecori commented Jul 1, 2019

FYI I think release was something we did because @thibautjombart wanted a version to use in the field in an Ebola outbreak (last year or the one before).
Are we happy with this and can we close this issue? @jstockwin and @zkamvar ?

@jstockwin
Copy link
Collaborator

Yep, this can definitely be closed!

@zkamvar
Copy link
Collaborator Author

zkamvar commented Jul 1, 2019

Agreed.

I believe the original idea behind the release branch was @richfitz. This was so that you could point the deployer to that branch and easily point people to the last known working version. The only problem was that it required you to actually push to the release branch every time you made a release.

@jstockwin
Copy link
Collaborator

Now that we have proper releases this isn't a problem, though? You can just target EpiEstim@v2.1-0.

@zkamvar
Copy link
Collaborator Author

zkamvar commented Jul 1, 2019

No, it isn't really a problem at all... It's just that someone needs to be on top of it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants