New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add sample_posterior_R function #76
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a code-style perspective this LGTM. This does not include a review of the mathematics of the actual function, though :)
Does EpiEstimApp require any changes from this?
No, the app shouldn't require any change from this. It is an extra feature. |
Codecov Report
@@ Coverage Diff @@
## master #76 +/- ##
=========================================
+ Coverage 49.07% 49.8% +0.72%
=========================================
Files 12 13 +1
Lines 1243 1251 +8
=========================================
+ Hits 610 623 +13
+ Misses 633 628 -5
Continue to review full report at Codecov.
|
@annecori, Can you take a look at this and see if it works for you? |
bumping @annecori to see if this function makes sense to her. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great thanks @zkamvar, I've only added a small comment explaining the set.seed call in the example, hope that's ok
This will fix #70, but I've modified it so that it takes from a specific time window of R:
Created on 2019-06-06 by the reprex package (v0.3.0)