Wallinga fix #93
Merged
Wallinga fix #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zkamvar Any chance you could take a look at this? |
This was referenced Apr 22, 2020
annecori
approved these changes
May 15, 2020
|
@jstockwin I am happy with your changes to the code, thanks for that. Not sure about tests etc, so can you please check that and merge yourself if you are happy the tests pass? Thanks |
|
@annecori actually when you click through they pass.. I'm re-running now |
|
hmm ok I was wrong - the tests are still failing, but only on xcode. Will try and find a way to fix that... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Closes #92
Fixes a bug where
draw_one_set_of_ancestrieswould return a result of the wrong length. It would calculate the length based on the time window, but everything else is based onT. I am not familiar with the actual maths involved here, so please do check this is correct.Fixes a bug where
otwas not defined.How has this been tested
Examples were given in #92, and these now work correctly.
Checklist
NEWS.mdwith a short description of my change