Use correct NA value for user handling #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #101 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 971 972 +1
=========================================
+ Hits 971 972 +1
Continue to review full report at Codecov.
|
hillalex
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As found by @annecori, we wrote code that performed poorly on an ARM Mac.
The testing is not ideal, but should at least prevent regressions. There's no obvious way of triggering this without running on an M1 which is not really possible in a CI environment. Fix confirmed on Anne's machine.