MRC-538: remove use of context/queuer #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Could go simpler, but these are fairly cute
Codecov Report
@@ Coverage Diff @@
## master #9 +/- ##
======================================
Coverage 100% 100%
======================================
Files 14 16 +2
Lines 849 955 +106
======================================
+ Hits 849 955 +106
Continue to review full report at Codecov.
|
This reduces the worker overhead by reducing the number of total roundtrips taken; we now have - BLPOP while waiting for job ($poll) - one pipeline while retrieving job (worker_run_task_start) - one pipeline while returning job (worker_run_task_cleanup)
r-ash
approved these changes
Oct 14, 2019
| @@ -0,0 +1,63 @@ | |||
| ## Adapted from queuer | |||
| time_checker <- function(timeout) { | |||
There was a problem hiding this comment.
This is a neat little function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes use of the
contextandqueuerpackages fromrrq. Doing this will allow us to do two things:lapply- like interface) in a way that fits better with the new environment creationThe bulk of the new code here was directly copied in from
context/queuerwith simplifications to remove unused code branches. The code inexpression.Rwill change when we do bulk submission, and includes a couple of options that are not (yet) exposed toenqueue. The progress bar bits are all a bit tedious, but nice for interactive use.