Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please rename content function #6

Closed
carlganz opened this issue Feb 3, 2020 · 6 comments
Closed

Please rename content function #6

carlganz opened this issue Feb 3, 2020 · 6 comments

Comments

@carlganz
Copy link

carlganz commented Feb 3, 2020

The content function can clash with the fairly popular httr::content function. I would recommend either name spacing your functions ie sg_content or thinking of a different name.

Thanks for the wonderful package.
@mrchypark
Copy link
Owner

Good suggestion.

package need refactoring to submit cran.
I'll change name content to sg_content.

Thank you!

@mrchypark mrchypark mentioned this issue Dec 19, 2020
Merged
@mrchypark
Copy link
Owner

function name content change to body.

@mrchypark
Copy link
Owner

@all-contributors please add @carlganz for ideas

@allcontributors allcontributors bot mentioned this issue May 1, 2021
Closed
@allcontributors
Copy link
Contributor

@mrchypark

I've put up a pull request to add @carlganz! 🎉

@mrchypark
Copy link
Owner

@all-contributors please add @carlganz for ideas

@allcontributors allcontributors bot mentioned this issue May 1, 2021
Merged
@allcontributors
Copy link
Contributor

@mrchypark

I've put up a pull request to add @carlganz! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mrchypark @carlganz