Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All classes should be in Minify namespace #305

Open
mrclay opened this issue Sep 4, 2015 · 2 comments
Open

All classes should be in Minify namespace #305

mrclay opened this issue Sep 4, 2015 · 2 comments

Comments

@mrclay
Copy link
Owner

mrclay commented Sep 4, 2015

Originally reported on Google Code with ID 161

Not really a defect.
Will there be an overhaul of the class structure in the near future?
My problem is that I'm only using the compressor classes (Minify_CSS and
JSMin), I'm serving the files for myself.
Minify's class structure makes it a little hard to include as an
svn:external right now, since I have to use the whole lib folder.
It would be nice if Minify would follow the regulations that all major PHP
projects keep right now, that the project name opens a namespace and
_every_ class is place under this namespace.
So there would only be Minify_* classes.
Doctrine and Zend Framework (and several others, like SabreDav, Yadif, ...)
do this already.
So JSMin and JSMinPlus would have to be renamed to Minify_JS and
Minify_JSPlus or something alike.

Any plans of doing this?

Minify version: release_2.1.3
PHP version: 5.3.1


Reported by stephan.wentz on 2010-02-04 23:22:44

@mrclay
Copy link
Owner Author

mrclay commented Sep 4, 2015

Yes, that's a good idea, but "near future" is unknown. I just haven't had a lot of
time to work at home lately and the desired items to overhaul are piling up. I really
need to do some thinking and define the next milestone.

I know the current Minify class will end up as Minify_Server. I've considered moving
the HTTP_ classes to a separate project, but then is it worth the maintenance headache...

Reported by mrclay.org on 2010-02-05 00:38:00

  • Labels added: Type-Enhancement, Priority-High, Milestone-2.2
  • Labels removed: Type-Defect, Priority-Medium

@mrclay
Copy link
Owner Author

mrclay commented Sep 4, 2015

That'd be really awesome.
I think there was a ticket regarding proposal as a Zend Framework component, if
you'll do this you will have to deal with this anyway (since it will have a prefix
like Zend_Minify_).

Reported by stephan.wentz on 2010-02-11 00:45:20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant