Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minify_groupUri() doesn't notice changes in file inclusion/order #383

Closed
mrclay opened this issue Sep 4, 2015 · 2 comments
Closed

Minify_groupUri() doesn't notice changes in file inclusion/order #383

mrclay opened this issue Sep 4, 2015 · 2 comments

Comments

@mrclay
Copy link
Owner

mrclay commented Sep 4, 2015

Closed: See #41.

Originally reported on Google Code with ID 241

Paul Schwarz noticed that "while it does a good job of checking whether files have been
*modified* it makes no attempt to notice whether the group itself has been modified,
i.e. adding or removing sources from the group" (or re-ordered).

i.e. GroupUri needs to append a hash of the array of filesnames along w/ the max timestamp.
Here's what I recommend:
* always starts with "0" so RewriteRules doesn't need to change
* md5(serialize(array(filenames) + array(maxTimestamp)))
* output MD5 in base64 and strip +/=

Reported by mrclay.org on 2011-09-03 11:48:57

@mrclay
Copy link
Owner Author

mrclay commented Sep 4, 2015

This won't work either. Including full filepaths and mtimes is the only way to catch
modifications. On the plus side it won't make MD5's output longer.

Reported by mrclay.org on 2011-09-03 11:55:26

@glensc
Copy link
Collaborator

glensc commented Jan 21, 2016

seems related: #28

so could be closed as duplicate of #41 ?

@mrclay mrclay closed this as completed Jan 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants