get_magic_quotes_gpc still used thus does not work properly in PHP 8.0 and later

[jugantner2]

In file lib/HTTP/ConditionalGet.php:319 the deprecated (in PHP 8.0 and later removed) function get_magic_quotes_gpc is used:

$clientEtagList = get_magic_quotes_gpc()
? stripslashes($_SERVER['HTTP_IF_NONE_MATCH'])
: $_SERVER['HTTP_IF_NONE_MATCH'];

I suggest to replace it with:
$clientEtagList = $_SERVER['HTTP_IF_NONE_MATCH'];

It worked for me.

Thanks,
Julian

[glensc]

Version info missing. This is already fixed:

• Function get_magic_quotes_gpc() is now deprecated in PHP 7.4 #665

[jugantner2]

Thanks Elan, I downloaded the latest release source 3.0.4 which is from 2019, so the issue is not fixed in this version.
Do you plan to release a new version with all current fixed and changes? Thanks, Julian

[glensc]

latest tag is 3.0.13:

• https://github.com/mrclay/minify/releases/tag/3.0.13

See the changelog:

• https://github.com/mrclay/minify/blob/39c37bdd8c600d202841f8bc3136070d6ab22d91/CHANGELOG.md

[BillyGeat]

For unknown reasons, the change / merge you made to solve this is gone and the "$clientEtagList = PHP_VERSION_ID < 50400 && get_magic_quotes_gpc()" is still / back there at line 320.
I downloaded the lattest v4 and also checked the file in the source tree here, both have the old code inside.
So, it does not work anymore in PHP v8+

[glensc]

The change is correct:

• Fix support for php 7.4 #677