Additional changes to make github actions happy. #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Returns empty string if algo was changed or "CPU doesnt support this feature." or "Library was built without this algorithm.". Tests fixed for that changes.
Closed
|
@bigcat88 Please pull in the latest changes to master, which should enable CI to run on pull requests. |
|
i saw that you added build for another archs, just to you to know, i didnt currently add code or test it on arm or anything else except x86, i will do that probably during two next weeks... p.s.: last |
|
Sounds good. FYI, I just published 2.2.0 to PyPI. Let me know if there are any further issues. In the meantime, I'll test usings cibuildwheel. As always, thank you for your contributions! |
|
@mrecachinas Can you please upload python 3.10 wheel? =) |
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-sparameter to pytest, to see output of tests.print(f'Warning: Skipping {algorithm}, reason: {result}')set_algonow checks if cpu can run those algorithm.P.S.:
On GitHub MacOS
sysctl -a | grep machdep.cpu.featuresreports that AVX is present(avx1.0) butcpuidreports thatavx2.0is not. So now set_algo checks for cpu capabilities and tests forextraon MacOS are currently skipped. It's fine with this.