Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arm, sdist, musli, windows builds. #18

Merged
merged 4 commits into from Feb 8, 2022
Merged

Arm, sdist, musli, windows builds. #18

merged 4 commits into from Feb 8, 2022

Conversation

bigcat88
Copy link
Contributor

@bigcat88 bigcat88 commented Feb 4, 2022

  • Moved version to separate file, to edit it in one place.
  • Slightly changed setup.py
  • In most functions changed return value from int to uint64_t.
  • The same for input length, changed it to uint64_t.
  • Added ARM implementation for hamming_distance_bytes__extra.
  • Added to YML file building of arm, sdist, musli, windows.
  • After publishing of wheels I will test them on M1(did not test cross building in cibuildwheel yet).

Note: 32 bit version fail tests, so did not added x86 build to Windows and i686 to linux.

#11 #12

#	.github/workflows/pythonpackage.yml
@mrecachinas mrecachinas deleted the branch mrecachinas:cibuildwheel February 5, 2022 01:32
@mrecachinas mrecachinas closed this Feb 5, 2022
@mrecachinas mrecachinas reopened this Feb 5, 2022
@mrecachinas
Copy link
Owner

Let me know when this is good for me to review and merge.

@bigcat88
Copy link
Contributor Author

bigcat88 commented Feb 7, 2022

@mrecachinas in last part of pull request reduce size of yml file by 50+ lines, make some adjustments.
Yes this is good.

It is final request, nothing left to make smaller in yml.
@bigcat88
Copy link
Contributor Author

bigcat88 commented Feb 7, 2022

@mrecachinas Now it is really final, nothing can be done to make yml smaller(only to rewrite building according to PEP 517, will do it in a month or two)

@mrecachinas
Copy link
Owner

LGTM

@mrecachinas mrecachinas merged commit b9f5e05 into mrecachinas:cibuildwheel Feb 8, 2022
mrecachinas added a commit that referenced this pull request Feb 10, 2022
* Use cibuildwheel in pythonpackage.yml

* Arm, sdist, musli, windows builds. (#18)

* # Conflicts:
#	.github/workflows/pythonpackage.yml

* clean up.

* clean up finished.

* Removed setup python step.
It is final request, nothing left to make smaller in yml.

Co-authored-by: Alexander Piskun <13381981+bigcat88@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants