Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.2.3 , Illegal Instruction fixed. #21

Merged
merged 1 commit into from Feb 13, 2022

Conversation

bigcat88
Copy link
Contributor

  • Changed version to 2.2.3
  • Add sdist upload to pypi.
  • Fixed Illegal Instruction.

P.S:
We can't add O2 flag to Linux builds, because then he automaticly replaces SSE with AVX.
We cant use snprintf without args on Linux, because for some reason g++ replace it with SSE instructions.

- Add sdist upload to pypi.
- Fixed Illegal Instruction.
@bigcat88
Copy link
Contributor Author

@mrecachinas tested wheels what Github generate after this PR(when there is only one snprintf), all was ok on Pentium4, Arm8, m1, Intel Core.
When there is two snprintf - like in 2.2.2, g++ uses sse instead of snprintf to optimize size and it fails in PyInit_hexhamming.
That is a strange magic with optimization in g++...

@mrecachinas
Copy link
Owner

Thanks as usual @bigcat88!

@mrecachinas mrecachinas merged commit 6041999 into mrecachinas:master Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants