Skip to content
This repository has been archived by the owner on Jan 24, 2020. It is now read-only.

Dependency issues with Tether, Bootstrap, CSS #1

Closed
enkodellc opened this issue Aug 31, 2017 · 4 comments
Closed

Dependency issues with Tether, Bootstrap, CSS #1

enkodellc opened this issue Aug 31, 2017 · 4 comments
Assignees
Labels

Comments

@enkodellc
Copy link

enkodellc commented Aug 31, 2017

Just tried installing this and having several dependency issues. Can you confirm with fresh install. I updated the Bootstrap to "bootstrap": "^4.0.0-beta",

  • Tether & Jquery
  • Bootstrap and their dependency with Popper - Uncaught Error: Bootstrap dropdown require Popper.js (https://popper.js.org)
  • _variables.scss are failing, (x: 0, y: 0) isn't a valid CSS value.
$spacers: (
  0: (
    x: 0,
    y: 0
  ),
  1: (
    x: $spacer-x,
    y: $spacer-y
  ),
  2: (
    x: ($spacer-x * 1.5),
    y: ($spacer-y * 1.5)
  ),
  3: (
    x: ($spacer-x * 3),
    y: ($spacer-y * 3)
  )
) !default;
@FezVrasta
Copy link

On a side note. Tether is not required by Bootstrap v4 beta

@enkodellc
Copy link
Author

Thanks @FezVrasta for the side note! Were you able to get everything to run or offer any solutions?

@mrellipse
Copy link
Owner

Thanks for the heads up! I can confirm I am getting the same error as well with a clean install.

Last time I updated the generator project, I was using a cheat to speed up testing (symlink to existing node_modules folder) so I didn't pick up on the breaking changes.

Will patch this up on the weekend, and update this thread with a resolution :)

@mrellipse mrellipse self-assigned this Sep 2, 2017
@mrellipse mrellipse added the bug label Sep 2, 2017
@mrellipse
Copy link
Owner

Okay, bug fixed.

👍 @enkodellc & @FezVrasta for taking an interest in the project!

Just no taking me to task about the dodgy bootstrap layout 😉 . I like to make it work, not make it pretty!

You can expect a few more updates soon related to localization & multi-language support. I didn't bake in UTC date handling, which will require a bit of work on the server side to sort out!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants