Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LocalSettingsManager class implementation is missing #2540

Closed
frobenius opened this issue Dec 29, 2023 · 8 comments
Closed

LocalSettingsManager class implementation is missing #2540

frobenius opened this issue Dec 29, 2023 · 8 comments
Assignees
Labels
1.77.3 Version 1.77.3 High Priority Project Infrastructure Relates to build, script, and release processes. DevOps type stuff.

Comments

@frobenius
Copy link

I clone repository and i can't build mRemoteNg because class LocalSettingsManager declaration and implementation is not in repository.

@Kvarkas
Copy link
Member

Kvarkas commented Dec 29, 2023

oh my bad, seems that bite leeked to repo then main part is not ready :) will fix, thanks for spoting.

@Kvarkas Kvarkas self-assigned this Dec 29, 2023
@Kvarkas Kvarkas added Project Infrastructure Relates to build, script, and release processes. DevOps type stuff. 1.77.3 Version 1.77.3 High Priority labels Dec 29, 2023
@pahtzo
Copy link

pahtzo commented Feb 10, 2024

Same issue here after cloning the repo. Is there any timeline to resolve this? thank you.

@xRushG
Copy link
Contributor

xRushG commented Mar 10, 2024

You don't need to wait for the fix if you've cloned the repo. Go to the file 'mRemoteNG\App\ProgramRoot.cs' and comment out (with // or /* [...] */) the lines as described in my comment for the merge: #2559. After you've done that, you can build the current version...

I'll try to start a second pull request in the next few days and comment out the lines. I don't want to delete them because I don't know if @Kvarkas needs them to complete the main part.

@pahtzo
Copy link

pahtzo commented Mar 10, 2024

Thank you, that worked for me.

@HorseLuke
Copy link

Hello xRushG. mRemoteNG support portable mode. Did merge #2559 made portable mode not portable?

@xRushG
Copy link
Contributor

xRushG commented Apr 28, 2024

Hey what exactly do you mean? Do you have an issue with compilation in visual studio?

Kvarkas added a commit that referenced this issue Apr 29, 2024
LocalSettingsManager class implementation is missing (#2540)
@tecxx
Copy link
Contributor

tecxx commented May 4, 2024

thanks for the programroot fix.

i noticed as well that something changed with the portable version. is it intended that "release installer and portable" links to "release" configuration?

image

@xRushG
Copy link
Contributor

xRushG commented May 4, 2024

Ah, okay, I see. There have been some changes in the project configuration since March 31, 2023. Everything was changed to release, but therefore I can't tell anything. Please open a new ticket to report this feature.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.77.3 Version 1.77.3 High Priority Project Infrastructure Relates to build, script, and release processes. DevOps type stuff.
Projects
None yet
Development

No branches or pull requests

6 participants