Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated version of ShowCaseView #14

Closed
wants to merge 34 commits into from
Closed

Conversation

JJSWART
Copy link

@JJSWART JJSWART commented Jul 31, 2018

The following features were added to accommodate one of my projects.

  • Set background color of showcase.
  • Set background color of message box
  • Set title text color
  • Set content text color
  • Make showcase a circle or rectangle
  • Added a previous and next arrow with a onclick listener. - Use the setArrowsClicked method.
  • Set Arrows to Show and Hide the arrows.
  • Set corner radius of rectangle.
  • Function to remove all tap dismiss events.
  • This enable custom events and arrows.
  • Add setClickable - false - no touch registered. Else touch registered and onDismiss can be called as default.

All defaults are set to existing defaults. Except the isClickable which is default false. The targetView click default is great but if you need the library to work in an app where you maybe utilize custom swipe events or click events it can be a problem.

  • TODO - change arrow position constructor/method to be added. Time constraint at the moment.

JJSWART and others added 5 commits July 31, 2018 11:44
The following features were added to accommodate one of my projects. 
- Set background color of showcase. 
- Set background color of message box
- Set title text color
- Set content text color
- Make showcase a circle or rectangle
- Added a previous and next arrow with a onclick listener. - Use the setArrowsClicked method. 
- Set Arrows to Show and Hide the arrows. 
- Set corner radius of rectangle. 
- Function to remove all tap dismiss events.
- This enable custom events and arrows.
- TODO - change arrow positions. Time constraint at the moment.
@mreram
Copy link
Owner

mreram commented Aug 1, 2018

Dear JJSWART,
It's not fair to apply a few changes to your code, but it's best to check them out and send a pull request.

@mreram mreram closed this Aug 1, 2018
@JJSWART
Copy link
Author

JJSWART commented Aug 2, 2018

Hi mreram.

I do not understand what is unfair?

I added an extensive amount of features to the library and send a pull request to you?

What do you mean by check them out? Please clarify so that I can make the corrections if needed.

Kind Regards.

@mreram
Copy link
Owner

mreram commented Aug 2, 2018

Hi JJSWART
Your features are very interesting.
I changed the different parts of your code. I said if you can review my changes and send pull request again(maybe you want to change a part).
Best Regards.

@mreram mreram reopened this Aug 2, 2018
@JJSWART
Copy link
Author

JJSWART commented Aug 3, 2018

Hi mreram.

Thanks, I will do that over the weekend.

Have a good day.

@dearpowa
Copy link

Can you please do something about this pull request?
It would be very usefull for me to use these new features

@mreram
Copy link
Owner

mreram commented Nov 5, 2019

Sorry,
Currently, I can't merge this pull request because there are many duplicate commits and issues.
I'll add these features later and I'll mention @JJSWART, but this pull request is open and @JJSWART can clean and review codes and I'll check if it's ok I'll merge it. thanks

@mreram mreram closed this Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants