Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust edition 2018, no_std default, README and CI changes #42

Merged
merged 2 commits into from
Oct 16, 2019

Conversation

akhilles
Copy link
Collaborator

  • extern crate ...; is deprecated.
  • Cargo features should be used for "additive" functionality. So, it makes sense to remove the std feature.
  • Modifying features requires version bump since it could be a breaking change.

.travis.yml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@akhilles akhilles changed the title Rust edition 2018, no_std default, documentation changes Rust edition 2018, no_std default, README and CI changes Sep 7, 2019
@akhilles
Copy link
Collaborator Author

akhilles commented Sep 7, 2019

I get the need to consolidate breaking changes into a major version release. Can this PR be merged into a 2.0.0-preview working branch?

@mrhooray
Copy link
Owner

mrhooray commented Sep 8, 2019

I'm good with working on top of master, optionally with 2.0.0-preview as version in cargo.toml. Gonna merge in next few days if no objections.

@akhilles
Copy link
Collaborator Author

@mrhooray can this be merged?

@mrhooray
Copy link
Owner

The build seems to fail on v1.31.0 https://travis-ci.org/mrhooray/crc-rs/builds/582183504

@akhilles
Copy link
Collaborator Author

Looks like int_to_from_bytes was stabilized in v1.32.0 and is needed for criterion. cargo bench should only run on nightly anyways. Will fix this.

@akhilles
Copy link
Collaborator Author

Turns out that criterion is compiled for cargo test as well as cargo bench. @mrhooray would you prefer to bump the MSRV to v1.32.0 or to keep using criterion v0.2?

@akhilles
Copy link
Collaborator Author

From criterion's compatibility policy:

Criterion.rs supports the last three stable minor releases of Rust. At time of writing, this means Rust 1.33 or later. Older versions may work, but are not tested or guaranteed.

Currently, the oldest version of Rust believed to work is 1.32. Future versions of Criterion.rs may break support for such old versions, and this will not be considered a breaking change. If you require Criterion.rs to work on old versions of Rust, you will need to stick to a specific patch version of Criterion.rs.

@mrhooray
Copy link
Owner

Happy with v1.32.0 unless you recommend otherwise.

@akhilles
Copy link
Collaborator Author

Bumped MSRV to v1.32.0 and squashed commits.

@mrhooray mrhooray merged commit 8c29492 into mrhooray:master Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants