-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latest commit (479783b165f39db94e97cff3432855f5a3cc07f2) broke IEEE checksum, at least. #51
Comments
See #52 for a possible reproduction of this issue. |
thanks for the repro. +@akhilles |
Looks like the new crc table generation code doesn't compute the 255th element in the table:
This is because the recursive macro only executes 255 times, not 256! Incredibly, none of the existing test cases were affected by this. This is a simple indexing issue, will submit fix shortly. |
We'll definitely need better test cases to identify these issues in the future. Maybe we can use a large binary blob (~1kb) of randomly generated data instead of just |
Yeah adding tests data other than standard check value could be helpful. Merging #53 and gonna add more test data separately. |
What about a range of randomly generated differently sized binary blobs? The test would be to compare the functions in this crate against third-party known-good implementations. |
I unfortunately lack time for a full repro right now, but maybe this will help. This code:
works right before that commit, but hits the error case after it.
The text was updated successfully, but these errors were encountered: