Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cached returns from actions (via getters) #4

Closed
mrichar1 opened this issue Oct 11, 2018 · 2 comments
Closed

Cached returns from actions (via getters) #4

mrichar1 opened this issue Oct 11, 2018 · 2 comments
Labels
enhancement New feature or request

Comments

@mrichar1
Copy link
Owner

There is the possibility for the action to be smarter about how it returns data. For example, it could return from the store immediately if the data is 'fresh' rather than always querying the API. This would improve performance.

This is probably best implemented by looking at cache timeout info as provided by the API, possibly some other headers like etags etc?

@mrichar1 mrichar1 changed the title Smart action returns via getter Cached returns from actions (via getters) Oct 11, 2018
@mrichar1 mrichar1 added the enhancement New feature or request label Oct 11, 2018
@stale
Copy link

stale bot commented Feb 19, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 19, 2019
@mrichar1 mrichar1 removed the stale label Feb 19, 2019
@mrichar1
Copy link
Owner Author

After developing and using this library for a while, it's apparent that for current use cases, caching at the API server end (cache-control, etags etc) is implemented at some level in most JSONAPI servers to an extent that local caching wouldn't add much benefit for the extra work that would be involved.

Closing this call for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant