Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overly unrestricted permissions #6

Closed
nick-ford opened this issue Aug 1, 2013 · 2 comments
Closed

Overly unrestricted permissions #6

nick-ford opened this issue Aug 1, 2013 · 2 comments

Comments

@nick-ford
Copy link

This feels pretty unsafe to install... Why not restrict to *.github.com?

image
@mridgway
Copy link
Owner

mridgway commented Aug 1, 2013

Because enterprise installations don't use the github.com domain. I do a restriction using the include_globs directive (https://github.com/mridgway/github-expand-diff/blob/master/manifest.json#L8), but I guess chrome doesn't show that in their installation confirmation.

@nick-ford
Copy link
Author

Hah - that's unfortunate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mridgway @nick-ford