Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition TypeScript definition to DefinitelyTyped #53

Closed
mridgway opened this issue Jun 8, 2018 · 5 comments
Closed

Transition TypeScript definition to DefinitelyTyped #53

mridgway opened this issue Jun 8, 2018 · 5 comments

Comments

@mridgway
Copy link
Owner

mridgway commented Jun 8, 2018

There has been a lot of churn in the type definitions which I am unable to test since I do not use TypeScript. Since the guidance from the TypeScript team is to use DefinitelyTyped for modules that are not natively written in TypeScript, that is what should be done.

Once a type definition has been published to DefinitelyTyped, I will remove the embedded index.d.ts file.

@mridgway
Copy link
Owner Author

I will be removing the definitions in the 3.x release regardless of presence of definitions in DefinitelyTyped.

@mridgway
Copy link
Owner Author

Since these are now removed in master, here are the old definitions for anyone that wants to add these to DefinitelyTyped: https://raw.githubusercontent.com/mridgway/hoist-non-react-statics/cc2234126197f89b9ac33d778899d55b1f089dfa/index.d.ts

@JounQin
Copy link

JounQin commented Jul 31, 2018

@mridgway My PR for declarations has been merged, and @types/hoist-non-react-statics has been published.

@mridgway
Copy link
Owner Author

@JounQin Thank you very much for doing this!

@hedgepigdaniel
Copy link

Just pointing out that this is the cause of DefinitelyTyped/DefinitelyTyped#33690 (comment)

Not sure what the right solution is, but it seems like once you've published a package with a types field in package.json, it will forever (sometimes) take precedence over DefinitelyTyped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants