Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Screen brightness going down somethimes when increasing value #1285

Closed
PilotOfGolf opened this issue Apr 4, 2024 · 3 comments
Closed
Labels
Confirmed but not a bug The behavior was confirmed but not considered a Professional firmware bug stale-closing-soon

Comments

@PilotOfGolf
Copy link

PilotOfGolf commented Apr 4, 2024

Did you test with a precompiled firmware?

Yes, and the problem still exists.

Bug Description

When changing the screen brightness, the screen brightness when increasing the value usually goes up, but it goes down at one point.

Bug Timeline

It has presisted since I have had the firmware (2-3 months)

Expected behavior

I expected the screen to increase the brightness as I increased the value.

Actual behavior

When I increased the value, the brightness usually increased. However at one point, the brightness decreased when increasing this value. This specifcally happens when going from 4 -> 5.

Steps to Reproduce

I was able to get this to reproduce when changing the brightness whilst printing, and whilst not printing. I put the steps to reproduce while not printing

  1. Navigate to screen brightness setting
  2. increase value steadily
  3. Notice that going from 4 to 5 the screen gets dimmer (This is the issue).

Version of Professional Firmware

2.1.3

Printer model

Ender 3 S1

Electronics

F4 Board (stock board)

LCD/Controller

Stock E3S1 Screen

Other add-ons

None related

Bed Leveling

ABL Bilinear mesh

Your Slicer

Prusa Slicer

Host Software

SD Card (headless)

Additional information & file uploads

This video shows the issue. https://drive.google.com/file/d/1XuYBCbVtvJy80d7Nw-c6eB_T4JGRJYVM/view?usp=drive_link

@mriscoc mriscoc added Confirmed but not a bug The behavior was confirmed but not considered a Professional firmware bug and removed Bug: Potential ? labels Apr 5, 2024
@mriscoc
Copy link
Owner

mriscoc commented Apr 5, 2024

Some displays units have that behaviour with the generic firmware version, there is not an unique Stock E3S1 Screen, you must to compare your screen with these 5 possible versions: https://github.com/mriscoc/Ender3V2S1/wiki/How-to-update-the-display
So, some displays need an custom firmware compiled for that units.

@mriscoc
Copy link
Owner

mriscoc commented Apr 10, 2024

For TJC displays the brightness range is defined like:

  #ifdef TJC_DISPLAY
    #define LCD_BRIGHTNESS_MIN 6
    #define LCD_BRIGHTNESS_MAX 40
    #define LCD_BRIGHTNESS_DEFAULT 20
  #else 

Copy link

This issue has had no activity in the last 60 days. Please add a reply if you want to keep this issue active, otherwise it will be automatically closed within 10 days.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Confirmed but not a bug The behavior was confirmed but not considered a Professional firmware bug stale-closing-soon
Projects
None yet
Development

No branches or pull requests

2 participants