Skip to content

Commit

Permalink
update contributing doc
Browse files Browse the repository at this point in the history
Change-Id: I3eda55b13ee8255c8a59f93422f462d8cd7a158d
  • Loading branch information
ndjensen committed Mar 24, 2016
1 parent c53e591 commit 2c1d4a8
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 1 deletion.
11 changes: 11 additions & 0 deletions CONTRIBUTING.md
@@ -1,5 +1,15 @@
# Contributing to Jep

## Build issues

Testing the build of Jep on the variety of possible platforms and environments
is difficult. It works well for Linux and OS X. Building on Windows poses
unique challenges that have been documented on the [Windows wiki page](https://github.com/mrj0/jep/wiki/Windows).
If your environment has build problems please search for a solution and post
your results to the mailing list so it is documented for others with a similar
environment.


## Reporting issues

Please only report issues that you believe are bugs or feature requests.
Expand All @@ -10,6 +20,7 @@ When reporting bugs please include the Python version, Java version, and
operating system. It is also helpful if you can recreate or simulate the
problem with a simple test with the Jep command line interpreter.


## Contributing code

If you're fixing an issue and it's not a lot of code, just go ahead and
Expand Down
1 change: 0 additions & 1 deletion src/jep/jep_util.c
Expand Up @@ -1178,7 +1178,6 @@ jvalue convert_pyarg_jvalue(JNIEnv *env,
jstring expTypeJavaName, actTypeJavaName = NULL;
const char *expTypeName, *actTypeName;


getName = (*env)->GetMethodID(env, JCLASS_TYPE, "getName",
"()Ljava/lang/String;");
expTypeJavaName = (*env)->CallObjectMethod(env, paramType, getName);
Expand Down

0 comments on commit 2c1d4a8

Please sign in to comment.